feat(RELEASE-1102): remove unused data.fbc parameters from fbc

this commit removes references of unused or unecessary parameters in FBC Release Pipeline and tasks, namely: iibServiceConfigSecret, iibServiceAccountSecret and iibOverwriteFromIndexCredential. Signed-off-by: Leandro Mendes <[email protected]>
hacbs-release · Sep 12, 2024 · 51787fe · 51787fe
1 parent ab209d9
commit 51787fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 22 deletions.
diff --git a/internal-services/catalog/iib-add-fbc-fragment-to-index-image-task.yaml b/internal-services/catalog/iib-add-fbc-fragment-to-index-image-task.yaml
@@ -4,7 +4,7 @@ kind: Task
 metadata:
   name: t-add-fbc-fragment-to-index-image
   labels:
-    app.kubernetes.io/version: "0.2.1"
+    app.kubernetes.io/version: "0.3.0"
   annotations:
     tekton.dev/pipelines.minVersion: "0.12.1"
     tekton.dev/tags: release
@@ -36,12 +36,6 @@ spec:
       type: string
       default: "300"
       description: Timeout seconds to receive the build state
-    - name: iibServiceConfigSecret
-      type: string
-      description: Secret with IIB service config to be used
-    - name: iibOverwriteFromIndexCredential
-      type: string
-      description: Secret with overwrite FromIndex credentials to be passed to IIB
     - name: iibServiceAccountSecret
       type: string
       description: Secret with IIB credentials to be used
@@ -74,17 +68,17 @@ spec:
         - name: IIB_SERVICE_URL
           valueFrom:
             secretKeyRef:
-              name: $(params.iibServiceConfigSecret)
+              name: iib-services-config
               key: url
         - name: IIB_OVERWRITE_FROM_INDEX_USERNAME
           valueFrom:
             secretKeyRef:
-              name: $(params.iibOverwriteFromIndexCredential)
+              name: iib-overwrite-fromimage-credentials
               key: username
         - name: IIB_OVERWRITE_FROM_INDEX_TOKEN
           valueFrom:
             secretKeyRef:
-              name: $(params.iibOverwriteFromIndexCredential)
+              name: iib-overwrite-fromimage-credentials
               key: token
         - name: KRB5_CONF_CONTENT
           valueFrom:

diff --git a/internal-services/catalog/iib-pipeline.yaml b/internal-services/catalog/iib-pipeline.yaml
@@ -16,14 +16,6 @@ spec:
       type: string
       default: ""
       description: The Snapshot in JSON format
-    - name: iibServiceConfigSecret
-      type: string
-      default: iib-services-config
-      description: Secret containing IIB service Config
-    - name: iibOverwriteFromIndexCredential
-      type: string
-      default: iib-overwrite-fromimage-credentials
-      description: Secret with overwrite FromImage credentials to be passed to IIB
     - name: iibServiceAccountSecret
       type: string
       description: Secret containing the credentials for IIB service
@@ -63,10 +55,6 @@ spec:
       params:
         - name: binaryImage
           value: $(params.binaryImage)
-        - name: iibServiceConfigSecret
-          value: $(params.iibServiceConfigSecret)
-        - name: iibOverwriteFromIndexCredential
-          value: $(params.iibOverwriteFromIndexCredential)
         - name: iibServiceAccountSecret
           value: $(params.iibServiceAccountSecret)
         - name: fbcFragment