Ci/cache refactor and ci versions update #436
Conversation
eruizalo
added
dependencies
github-actions
bot
added
documentation
|
Test summary report 📊
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
This is an auto-generated comment created by:
eruizalo
force-pushed
the
ci/cache_refactor_and_ci_versions_update
branch
from
eda5fbd
to
af81780
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 97.69% 97.70% +0.01%
==========================================
Files 62 64 +2
Lines 1255 1259 +4
Branches 37 37
==========================================
+ Hits 1226 1230 +4
Misses 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| with: | ||
| extraKey: "${{ env.SPARK_VERSION }}" | ||
| jvm: adopt:8 |
There was a problem hiding this comment.
something is not working fine here
before --> [info] welcome to sbt 1.9.9 (AdoptOpenJDK Java 1.8.0_292)
after --> [info] welcome to sbt 1.9.9 (Eclipse Adoptium Java 11.0.22)
There was a problem hiding this comment.
Is using a different JVM but is it affecting something?
There was a problem hiding this comment.
I thought cache won't affect Java, but it seems if cache works Java is not set (we are now skipping the "install" step)
There was a problem hiding this comment.
Could it be that you exchange the cache step with the prepare step? It's something that I see suspicious
There was a problem hiding this comment.
no, it is supposed to execute cache before the install so you avoid this step, that should not be the problem. The problem is that if we match a cache we shouldn't install anything else, I mean this section apps: sbt scala scalafmt. As we don't need to install those apps because they should be provided by the cache, I ignored the step completely, but the step not only install those apps, but it set the java version as well (jvm: adopt:8). Because the whole step is now ignored if there is a cache hit, the java set is ignored as well, so I would probably add a new step only setting the java version if there is a cache hit... but it is kind of weird and I'm trying to determine if cache is needed at all, because our build times are not much better with the cache step
Description
Right now cache action is executing later than it should be, creating tons of caches and not using them. Now we are sharing the cache and avoiding the install action if it is not needed
Related Issue and dependencies
How Has This Been Tested?