Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for check button #26

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Add configuration for check button #26

merged 1 commit into from
Jun 12, 2017

Conversation

yukhnevych
Copy link
Contributor

@yukhnevych yukhnevych commented Jun 2, 2017 •
edited
Loading

@icc this is the part of H5P.QuestionSet pull request.

@yukhnevych yukhnevych mentioned this pull request Jun 2, 2017
Merged
@icc icc merged commit b9901e1 into h5p:master Jun 12, 2017
icc added a commit that referenced this pull request Jun 12, 2017
@icc
Revert "Merge pull request #26 from SergeyYukhnevich/add-configuratio…
f4de01a 
…n-for-check-button"

This reverts commit b9901e1, reversing
changes made to 7b1bff3.
@icc
Copy link
Member

icc commented Jun 23, 2017

Thanks for the pull request. I've created an issue for getting it merged in: HFP-1217

The following needs to be fixed before this can be merged in:

  1. Adding new fields to the top of an array in semantics.json require that all the translation files in language/ are updated, if not the labeling in the editor will be incorrect for those using the translations.
  2. The new field should us a conditional widget to hide the checkboxes used to disable the other buttons. This makes for a cleaner UI as changing the new checkbox always makes the other buttons hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukhnevych @icc