Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ implement getPreferences and getDefaultPostPrivacy for Firefish #1959

Merged

Conversation

ThatOneCalculator
Copy link
Contributor

Good-enough for now implementation for Firefish accounts/preferences

@ThatOneCalculator ThatOneCalculator force-pushed the feat/get-default-post-privacy branch from b25c54c to c8cb9b4 Compare October 6, 2023 05:54
@ThatOneCalculator
Copy link
Contributor Author

I'm honestly unsure why this happens. I don't get this locally when linting...

image

@h3poteto
Copy link
Owner

h3poteto commented Oct 7, 2023

It will be resolved by #1962
Please rebase this PR with the master branch.

@ThatOneCalculator
Copy link
Contributor Author

@h3poteto Thank you for fixing that issue :) All checks pass now

megalodon/src/firefish.ts Outdated Show resolved Hide resolved
Copy link
Owner

@h3poteto h3poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@h3poteto h3poteto merged commit 41a2807 into h3poteto:master Oct 8, 2023
7 checks passed
@ThatOneCalculator ThatOneCalculator deleted the feat/get-default-post-privacy branch October 8, 2023 08:24
@ThatOneCalculator ThatOneCalculator mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants