Merge newBase into develop #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8 * Added tsc command * Updated .travis.yml
* removed linting errors * removed linting errors * removed linting errors * removed linting errors * remove one un-neccessary commit * cleared the renderer file Co-authored-by: Piyush Agrawal <[email protected]>
poush
approved these changes
Apr 3, 2020
poush
requested changes
Apr 3, 2020
There was a problem hiding this comment.
Might have to squash some commits. @shashaBot what do you think moving it to a new branch develop instead of master and keep master for releases.
|
@poush Sounds good, we could do that |
poush
added a commit
that referenced
this pull request
Jun 20, 2020
* tsc * actions wip * Refactored, added Config Singleton * readme update * Update README.md * few changes on architecture * remove deprecated files * bumped license * fix: keyCombinations * bumped electron to 8.2.0, running basic version * Added tsc and lint command to .travis.yml (#11) Fixes #8 * Added tsc command * Updated .travis.yml * removed before_scripts from travis file * Fix: existing linting errors (#15), build passes from here * removed linting errors * cleared the renderer file Co-authored-by: Piyush Agrawal <[email protected]> Co-authored-by: Piyush Agrawal <[email protected]> Co-authored-by: Shashwat Gulyani <[email protected]> Co-authored-by: Divija Palleti <[email protected]> Co-authored-by: Muskan0510 <[email protected]>
poush
added a commit
that referenced
this pull request
Jun 20, 2020
* tsc * actions wip * Refactored, added Config Singleton * readme update * Update README.md * few changes on architecture * remove deprecated files * bumped license * fix: keyCombinations * bumped electron to 8.2.0, running basic version * Added tsc and lint command to .travis.yml (#11) Fixes #8 * Added tsc command * Updated .travis.yml * removed before_scripts from travis file * Fix: existing linting errors (#15), build passes from here * removed linting errors * cleared the renderer file Co-authored-by: Piyush Agrawal <[email protected]> Co-authored-by: Piyush Agrawal <[email protected]> Co-authored-by: Divija Palleti <[email protected]> Co-authored-by: Muskan0510 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4
new core framework of h2