Added pre-commit and pre-push hook #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashaBot
requested changes
Mar 29, 2020
| @@ -9,7 +9,9 @@ | |||
| "lint": "tslint -c tslint.json -p tsconfig.json", | |||
| "start": "npm run build && electron ./dist/main.js", | |||
| "lint:fix": "eslint ./src/**/*.js ./tests/**/*.js --fix", | |||
| "test": "mocha tests/spec.js --timeout 30000" | |||
| "test": "mocha tests/spec.js --timeout 30000", | |||
| "precommit": "npm run lint && npm test", | |||
There was a problem hiding this comment.
Please upgrade the hooks configuration according to the documentation here
| @@ -9,7 +9,9 @@ | |||
| "lint": "tslint -c tslint.json -p tsconfig.json", | |||
| "start": "npm run build && electron ./dist/main.js", | |||
| "lint:fix": "eslint ./src/**/*.js ./tests/**/*.js --fix", | |||
| "test": "mocha tests/spec.js --timeout 30000" | |||
| "test": "mocha tests/spec.js --timeout 30000", | |||
| "precommit": "npm run lint && npm test", | |||
There was a problem hiding this comment.
Also, you had to add tsc command for checking compilation errors
There was a problem hiding this comment.
Okay, was initially confused. Added it :)
There was a problem hiding this comment.
You latest commit does not have changes to this file. Please add your changes and update again.
Fixes h2org#8 * Added tsc command * Updated .travis.yml
shashaBot
requested changes
Mar 30, 2020
* removed linting errors * removed linting errors * removed linting errors * removed linting errors * remove one un-neccessary commit * cleared the renderer file Co-authored-by: Piyush Agrawal <[email protected]>
|
Please rebase, I have changed the base branch. |
poush
force-pushed
the
develop
branch
2 times, most recently
from
f47baa3 to
9a54c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9