Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure hardware pointer events do not reach underlying webview #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Frank3K
Copy link
Collaborator

@Frank3K Frank3K commented Jul 26, 2023

This fixes the issue on iOS and Android (including Chromebook) where hardware mouse events were being captured by an underlying webview.

Please note that we've included webview_flutter such that WebViewWidget can be used a native platform widget. This could probably have been another native platform widget.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This fixes the issue on iOS and Android (including Chromebook) where hardware mouse events were being captured by an underlying webview.
Frank3K pushed a commit that referenced this pull request Apr 5, 2024
flutter/flutter@58ba6c2...72b69f9

2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 [email protected] Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576)
2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 [email protected] ð��� Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Frank3K pushed a commit that referenced this pull request Apr 5, 2024
Roll Flutter from 29b2516 to f5a9835 (101 revisions)

flutter/flutter@29b2516...f5a9835

2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807)
2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708)
2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948)
2023-11-06 [email protected] Roll Packages from cccf5d2 to 49eac1f (2 revisions) (flutter/flutter#137943)
2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624)
2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941)
2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935)
2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611)
2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933)
2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837)
2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921)
2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920)
2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914)
2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912)
2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908)
2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904)
2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903)
2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900)
2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898)
2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892)
2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887)
2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835)
2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877)
2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210)
2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791)
2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872)
2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601)
2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863)
2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871)
2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879)
2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861)
2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865)
2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793)
2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840)
2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858)
2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857)
2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788)
2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853)
2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847)
2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846)
2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845)
2023-11-03 [email protected] Roll Packages from 33c2b4e to cccf5d2 (6 revisions) (flutter/flutter#137841)
2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874)
2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170)
2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806)
2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant