Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_web] Improve support for JavaScript channels #2

Open
wants to merge 3 commits into
base: feat/javascript-channels
Choose a base branch
from
Open

[webview_flutter_web] Improve support for JavaScript channels #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed8756e
feat: improve security
Frank3K Jun 21, 2023
cd8452c
feat: prevent messages from being processed more than once
Frank3K Jun 21, 2023
ed1a1f3
fix: add type check to event.data
jeroenbell Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions packages/webview_flutter/webview_flutter_web/lib/src/web_webview_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class WebWebViewControllerCreationParams
// ignore: avoid_unused_constructor_parameters
PlatformWebViewControllerCreationParams params, {
@visibleForTesting
HttpRequestFactory httpRequestFactory = const HttpRequestFactory(),
HttpRequestFactory httpRequestFactory = const HttpRequestFactory(),
}) : this(httpRequestFactory: httpRequestFactory);

static int _nextIFrameId = 0;
Expand Down Expand Up @@ -118,8 +118,35 @@ class WebWebViewController extends PlatformWebViewController {
) async {
void handler(html.Event event) {
if (event is html.MessageEvent) {
final String? iFrameSrc = _webWebViewParams.iFrame.src;
if (event.origin.isEmpty || iFrameSrc == null) {
return;
}

// Security check
if (!iFrameSrc.startsWith(event.origin)) {
return;
}

if (event.data == null || event.data is! Map) {
return;
}

// ignore: avoid_dynamic_calls
final String? channelName = event.data['channel'] as String?;
if (channelName != javaScriptChannelParams.name) {
return;
}

// ignore: avoid_dynamic_calls
final String? message = event.data['message'] as String?;
if (message == null) {
return;
}

javaScriptChannelParams.onMessageReceived(
JavaScriptMessage(message: event.data.toString()));
JavaScriptMessage(message: message),
);
}
}

Expand Down
Loading