Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_deb.sh #381

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

mzpqnxow
Copy link
Contributor

When using ./install_deb.sh on an x86_64 Debian Bullseye system, I get this:

11:24:21 › ./install_deb.sh 
This script only supports x86_64 and aarch64

This is because uname -p is being used to get the CPU architecture

11:25 › lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

11:25 › uname --help
Usage: uname [OPTION]...
Print certain system information.  With no OPTION, same as -s.

  -a, --all                print all information, in the following order,
                             except omit -p and -i if unknown:
  -s, --kernel-name        print the kernel name
  -n, --nodename           print the network node hostname
  -r, --kernel-release     print the kernel release
  -v, --kernel-version     print the kernel version
  -m, --machine            print the machine hardware name
  -p, --processor          print the processor type **(non-portable)**
  -i, --hardware-platform  print the hardware platform (non-portable)
  -o, --operating-system   print the operating system
      --help     display this help and exit
      --version  output version information and exit

GNU coreutils online help: <https://www.gnu.org/software/coreutils/>
Full documentation <https://www.gnu.org/software/coreutils/uname>
or available locally via: info '(coreutils) uname invocation'
11:25 › uname -p
unknown
11:25 › uname -m
x86_64

I'm surprised this hasn't been an issue for others... do I have some bizarro configuration? shrug

Use uname -m, not uname -p (which is not portable, and doesn't work on my x86_64 Bullseye install)
@emil916
Copy link
Contributor

emil916 commented Oct 23, 2023

Wow! You are absolutely right! I guess we never really tested on other distros, mainly on Ubuntu LTSs with x86 and ARM.
Thank you for the fix! Merging...

@emil916 emil916 merged commit 4e1f679 into gwsystems:master Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants