Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of a new address (without --replace option) #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fsommer
Copy link

@fsommer fsommer commented Jul 24, 2019

The execute method does not have a significant result value. The
present variable just contains the cursor object, which is always
true. Therefore the else-case for creating a new address entry can't
be reached.

To fix the behavior we need to fetch the result of the select statement.
If the statement doesn't match anything the fetched result will be
None which evaluates to false and leads to creation of a new address
entry.

The `execute` method does not have a significant result value. The
`present` variable just contains the cursor object, which is always
`true`. Therefore the else-case for creating a new address entry can't
be reached.

To fix the behavior we need to fetch the result of the select statement.
If the statement doesn't match anything the fetched result will be
`None` which evaluates to `false` and leads to creation of a new address
entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant