PR to evaluate diff from latest change common with the upstream #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the function launch_cli to launch the "cli" mode - add the the class Gnpy_API to launch the "api" mode - modify the main to enable the launch of Gnpy with two modes "rest" and "cli" Signed-off-by: ahmed <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
on the same topology file find the triangle topology
site_c
/ \
/ \
site_a ------ Site_b
and the simple parallel link
site_a ------ Site_b
\ /
--
this topo includes only sinple span hops and roadm have boosters and amplifiers
the serviceDemov1.json gives the example of how the requests must be formulated
- 0 simple one
- 1 request with the forced Span (case of parallel link)
- 2 request with the forced roadm (case of triangle topo)
- 3 and 4 request with the disjunction
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
- remove unused abort and marshall
- change variable names to conform to upper letter rule,
[a-z_][a-z0-9_]{2,30}$
- add docstrings
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: EstherLerouzic <[email protected]>
The check on node_list constraint has to be be done on all elements except the last one,
and the last one is always a "STRICT" value. this means that if no constraints are given
this list is equals to ["STRICT"]. Previous code was using len("STRICT") ie 6 instead of
len(["STRICT"]) ie 1.
Signed-off-by: EstherLerouzic <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to remove TPCE adherency from the GNPY docker image.
To this purpose, I think the best option is to create a PyPi / Cheese Shop package based on this work and add it in tox requirements.