Add ColorPicker (true color) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication init stuff that breaks with parallel tests
BDisp
approved these changes
Aug 24, 2024
| @@ -6,7 +6,7 @@ namespace UnitTests; | |||
| [TestOf( typeof( DimExtensions ) )] | |||
| [Category( "Core" )] | |||
| [Category( "Terminal.Gui Extensions" )] | |||
| [Parallelizable( ParallelScope.Children )] | |||
| [NonParallelizable] | |||
There was a problem hiding this comment.
Instead using [NonParallelizable] attribute everywhere, I think it's possible prevent parallel execution via .runsettings:
<RunSettings>
<NUnit>
<DefaultTestCaseParallelization>false</DefaultTestCaseParallelization>
</NUnit>
</RunSettings>There was a problem hiding this comment.
Yeah you are right - I think this is the default so I could probably just have deleted the attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump all nuget packages and add designer support for the new true color ColorPicker
Incidental changes
Equals) objects on all properties. But most of the properties of Views these days are complex and/or don't support equality. The test itself is kinda pointless.