New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: use selectorLabels helper #95

Merged

guerzon merged 1 commit into guerzon:main from craigcabrey:craigcabrey/fix/service-selector

Aug 27, 2024

Contributor

craigcabrey commented Jun 29, 2024

fixes #93

before:

$ helm template release ./vaultwarden
[snip]
apiVersion: v1
kind: Service
metadata:
  name: release-vaultwarden
  namespace: default
  labels:
    app.kubernetes.io/component: vaultwarden
    helm.sh/chart: vaultwarden-0.23.0
    app.kubernetes.io/name: vaultwarden
    app.kubernetes.io/instance: release
    app.kubernetes.io/version: "1.30.3"
    app.kubernetes.io/managed-by: Helm
spec:
  type: "ClusterIP"
  selector:
    app.kubernetes.io/component: vaultwarden
  ports:
    - name: "http"
      port: 80
      protocol: TCP
      targetPort: 8080
    - name: "websocket"
      port: 3012
      protocol: TCP
      targetPort: 3012
  ipFamilyPolicy: SingleStack
[snip]

after:

$ helm template release ./vaultwarden
[snip]
kind: Service
metadata:
  name: release-vaultwarden
  namespace: default
  labels:
    app.kubernetes.io/component: vaultwarden
    helm.sh/chart: vaultwarden-0.23.0
    app.kubernetes.io/name: vaultwarden
    app.kubernetes.io/instance: release
    app.kubernetes.io/version: "1.30.3"
    app.kubernetes.io/managed-by: Helm
spec:
  type: "ClusterIP"
  selector:
    app.kubernetes.io/name: vaultwarden
    app.kubernetes.io/instance: release
[snip]

guerzon reviewed

View reviewed changes

charts/vaultwarden/templates/service.yaml Show resolved Hide resolved

guerzon requested changes

View reviewed changes

Owner

guerzon left a comment •

edited

Loading

Thanks for the PR @craigcabrey. I have opened 1 review.

Also, please pull and update your repo and bump the chart version. Thanks.


          service: use selectorLabels helper

868b49b

craigcabrey force-pushed the craigcabrey/fix/service-selector branch from 7e23e18 to 868b49b Compare

August 27, 2024 19:25

guerzon approved these changes

View reviewed changes

guerzon merged commit eac4a45 into guerzon:main

1 check passed

craigcabrey deleted the craigcabrey/fix/service-selector branch

August 27, 2024 19:48

dc-tec referenced this pull request in dc-tec/k8s-gitops


          chore(deps): update helm release vaultwarden to v0.25.2 (#36)

0ca18e1

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [vaultwarden](https://redirect.github.com/guerzon/vaultwarden) |
HelmChart | minor | `0.24.1` -> `0.25.2` |

---

### Release Notes

<details>
<summary>guerzon/vaultwarden (vaultwarden)</summary>

###
[`v0.25.2`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.2)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.25.1...v0.25.2)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- fix: incomplete fix, additional by
[@&#8203;guerzon](https://redirect.github.com/guerzon) in
[https://github.com/guerzon/vaultwarden/pull/113](https://redirect.github.com/guerzon/vaultwarden/pull/113)

**Full Changelog**:
guerzon/vaultwarden@v0.25.1...v0.25.2

###
[`v0.25.1`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.1)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.25.0...v0.25.1)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- fix: make customHeadersConfigMap optional by
[@&#8203;guerzon](https://redirect.github.com/guerzon) in
[https://github.com/guerzon/vaultwarden/pull/112](https://redirect.github.com/guerzon/vaultwarden/pull/112)

**Full Changelog**:
guerzon/vaultwarden@v0.25.0...v0.25.1

###
[`v0.25.0`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.25.0)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.4...v0.25.0)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- feat: Replace nginx snippet annotation with custom header annotation
by [@&#8203;HerrSpeck](https://redirect.github.com/HerrSpeck) in
[https://github.com/guerzon/vaultwarden/pull/106](https://redirect.github.com/guerzon/vaultwarden/pull/106)

#### New Contributors

- [@&#8203;HerrSpeck](https://redirect.github.com/HerrSpeck) made their
first contribution in
[https://github.com/guerzon/vaultwarden/pull/106](https://redirect.github.com/guerzon/vaultwarden/pull/106)

**Full Changelog**:
guerzon/vaultwarden@v0.24.4...v0.25.0

###
[`v0.24.4`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.4)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.3...v0.24.4)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- service: use selectorLabels helper by
[@&#8203;craigcabrey](https://redirect.github.com/craigcabrey) in
[https://github.com/guerzon/vaultwarden/pull/95](https://redirect.github.com/guerzon/vaultwarden/pull/95)

#### New Contributors

- [@&#8203;craigcabrey](https://redirect.github.com/craigcabrey) made
their first contribution in
[https://github.com/guerzon/vaultwarden/pull/95](https://redirect.github.com/guerzon/vaultwarden/pull/95)

**Full Changelog**:
guerzon/vaultwarden@v0.24.3...v0.24.4

###
[`v0.24.3`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.3)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.2...v0.24.3)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- fix: add flag to enable notifications service by
[@&#8203;guerzon](https://redirect.github.com/guerzon) in
[https://github.com/guerzon/vaultwarden/pull/110](https://redirect.github.com/guerzon/vaultwarden/pull/110)

**Full Changelog**:
guerzon/vaultwarden@v0.24.2...v0.24.3

###
[`v0.24.2`](https://redirect.github.com/guerzon/vaultwarden/releases/tag/v0.24.2)

[Compare
Source](https://redirect.github.com/guerzon/vaultwarden/compare/v0.24.1...v0.24.2)

vaultwarden is an unofficial Bitwarden-compatible server written in Rust

#### What's Changed

- Push Notifications existing secret by
[@&#8203;Yannik26](https://redirect.github.com/Yannik26) in
[https://github.com/guerzon/vaultwarden/pull/107](https://redirect.github.com/guerzon/vaultwarden/pull/107)

#### New Contributors

- [@&#8203;Yannik26](https://redirect.github.com/Yannik26) made their
first contribution in
[https://github.com/guerzon/vaultwarden/pull/107](https://redirect.github.com/guerzon/vaultwarden/pull/107)

**Full Changelog**:
guerzon/vaultwarden@v0.24.1...v0.24.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=-->

Co-authored-by: Renovate Bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet