Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Async Streaming #53

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Fix Async Streaming #53

merged 5 commits into from
Jul 3, 2024

Conversation

nichwch
Copy link
Contributor

@nichwch nichwch commented Jun 28, 2024

Adds checks to if llm_callable is async, then awaits calls downstream if they are.

@nichwch nichwch requested a review from CalebCourier June 28, 2024 21:07
@CalebCourier

This comment was marked as resolved.

Sign in to view
CalebCourier
CalebCourier approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@CalebCourier CalebCourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's a strange issue both Nick and I encountered with Async Streaming where the prompt isn't always getting passed through, but it looks like it's likely a client side issue

@nichwch nichwch merged commit 86e0b6f into main Jul 3, 2024
1 check passed
@nichwch nichwch deleted the nichwch/fix-async-streaming branch July 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebCourier CalebCourier CalebCourier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nichwch @CalebCourier