Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: Shorten reservation ID #4189

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

mssalvatore
Copy link
Collaborator

Per Issue #4187, there are cases when download strings must be shorter. In order to achieve this, random strings from a set of 62 characters are generated. Using 5 characters gives something like 916M possible values, which is more than enough for any single agent.

What does this PR do?

Issue #4187.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Per Issue #4187, there are cases when download strings must be shorter.
In order to achieve this, random strings from a set of 62 characters are
generated. Using 5 characters gives something like 916M possible values,
which is more than enough for any single agent.

Issue #4187
PR #4189
@mssalvatore mssalvatore merged commit 6a5f9a1 into develop Jun 10, 2024
1 check failed
@mssalvatore mssalvatore deleted the 4187-shorten-reservation-ids branch June 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants