Final plugin changes #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakekoa
reviewed
Jul 19, 2024
cakekoa
reviewed
Jul 19, 2024
ilija-lazoroski
force-pushed
the
final-plugin-changes
branch
from
948231b
to
a66e129
Compare
cakekoa
reviewed
Jul 24, 2024
Comment on lines
+46
to
+48
| {%- if cookiecutter.__project_type!="agent_plugin" %} | ||
| version = "v0.1.0" | ||
| {%- endif %} |
There was a problem hiding this comment.
I think we still want to default the version to v0.1.0, even for plugins?
There was a problem hiding this comment.
Well this version is for the project not the plugin. Our plugins project are not importable as packages (at least not now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.