Add a build_permission_change_command method to ILinuxAgentCommandBuilder #10
Conversation
| @@ -47,6 +47,12 @@ def build_download_command(self, download_options: LinuxDownloadOptions): | |||
| :param download_options: Options needed for the command to be built | |||
| """ | |||
|
|
|||
| @abc.abstractmethod | |||
| def build_chmod_command(self): | |||
There was a problem hiding this comment.
- Should this be
build_set_permissions_command()? I knowchmodis normally how that's done, but there are conceivably other ways of getting the job done. - Should this accept a parameter for what the permissions should be? If so, should it be a single parameter or should we build an
Optionsmodel like we do for the other two commands.
There was a problem hiding this comment.
If command builder is a utility to build command/bash statements then we should be specific. If there's another way to change permissions we'll have to add it to the interface, because it will be a different bash statement.
| @@ -20,6 +20,11 @@ class LinuxDownloadOptions(InfectionMonkeyBaseModel): | |||
| download_url: str | |||
|
|
|||
|
|
|||
| class LinuxPermissionChangeOptions(InfectionMonkeyBaseModel): | |||
| file_path: PurePosixPath | |||
| permissions: int = Field(ge=0, le=777) | |||
There was a problem hiding this comment.
| permissions: int = Field(ge=0, le=777) | |
| permissions: int = Field(ge=0, le=0o777) |
There was a problem hiding this comment.
NIT: I recommend "LinuxChangePermissionsOptions"
| def build_permission_change_command(self, | ||
| permission_change_options: LinuxPermissionChangeOptions): |
There was a problem hiding this comment.
NIT: I recommend "build_change_permissions_command"
VakarisZ
force-pushed
the
add-chmod-command
branch
from
0cc8393
to
a02c7f1
Compare
| @@ -20,6 +20,11 @@ class LinuxDownloadOptions(InfectionMonkeyBaseModel): | |||
| download_url: str | |||
|
|
|||
|
|
|||
| class LinuxPermissionChangeOptions(InfectionMonkeyBaseModel): | |||
| file_path: PurePosixPath | |||
| permissions: int = Field(ge=0, le=777, default=700) | |||
There was a problem hiding this comment.
| permissions: int = Field(ge=0, le=777, default=700) | |
| permissions: int = Field(ge=0, le=0o777, default=0o700) |
VakarisZ
force-pushed
the
add-chmod-command
branch
from
a02c7f1
to
2e781f8
Compare
vulture_allowlist.py
Outdated
| ILinuxAgentCommandBuilder.build_permission_change_command | ||
| ILinuxAgentCommandBuilder.permission_change_options |
There was a problem hiding this comment.
We should remove vulture from this repository
There was a problem hiding this comment.
Probably. The right way to go about it is to make it an option in the cookiecutter template and then use cruft to update this repo and not include it.
|
Feel free to rename, but it's annoying since it has to be done manually, because it's a separate repository, so I prefer not to spend time on it |
VakarisZ
changed the title
mssalvatore
force-pushed
the
add-chmod-command
branch
from
53f9bf9
to
a7c51d0
Compare
The name of this member is changed to be consistent with the other `Options` models.
mssalvatore
force-pushed
the
add-chmod-command
branch
from
a7c51d0
to
0a0a4e6
Compare
mssalvatore
force-pushed
the
add-chmod-command
branch
from
0a0a4e6
to
a417515
Compare
Issue guardicore/monkey#4187