Drop play-json-extensions dependency
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/play-json-extensions
branch
from
b65d124 to
76a8622
Compare
AshCorr
commented
Apr 16, 2024
| @@ -69,10 +68,6 @@ lazy val root = (project in file(".")) | |||
| "ch.qos.logback" % "logback-classic" % "1.5.5", | |||
| "com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.17.0" | |||
| ), | |||
| excludeDependencies ++= Seq( | |||
| // As of Play 3.0, groupId has changed to org.playframework; exclude transitive dependencies to the old artifacts | |||
| ExclusionRule(organization = "com.typesafe.play") | |||
There was a problem hiding this comment.
play-json-extensions was trying to bring in com.typesafe.play:play-json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Drops the
play-json-extensionsdependency. This dependency was used to auto-generate JSON Writer implementations for case classes with more than 22 fields.Unfortunately it appears this dependency hasn't been updated in a long time and doesn't fully support Play 3 yet causing us to have to do some trickery with dependencies to avoid loading in any Play 2 dependencies, specifically Akka.
Thankfully we only had 1 class that was using this extension which was quite easy to write a custom JSON Writer implementation for.