Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple crosswords on one page #1809

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Handle multiple crosswords on one page #1809

merged 7 commits into from
Nov 22, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Nov 22, 2024 •
edited
Loading

What are you changing?

  • adds a getId function to the main crossword component that returns strings prefixed with the crossword id
  • uses it for the a11y attributes in clues

Why?

make sure crosswords work if there's more than one on a page

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Nov 22, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Nov 22, 2024
@sndrs sndrs self-assigned this Nov 22, 2024
@sndrs sndrs requested a review from a team as a code owner November 22, 2024 11:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: de228d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Nov 22, 2024
@sndrs sndrs linked an issue Nov 22, 2024 that may be closed by this pull request
Make sure multiple players on one page is fine guardian/dotcom-rendering#12856
Closed
@sndrs sndrs force-pushed the sndrs/crosswords/multiple-players branch from 64e2b96 to ec3e75e Compare November 22, 2024 13:55
oliverabrahams
oliverabrahams approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

oliverabrahams
oliverabrahams approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍 🥇

@sndrs sndrs enabled auto-merge November 22, 2024 16:48
@sndrs sndrs merged commit 42da65c into main Nov 22, 2024
20 of 21 checks passed
@sndrs sndrs deleted the sndrs/crosswords/multiple-players branch November 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees

@sndrs sndrs

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
WebX Team
Status: Done
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.

Make sure multiple players on one page is fine
2 participants
@sndrs @oliverabrahams