Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TypeScript to v5.5.2 in all packages #1593

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Bump TypeScript to v5.5.2 in all packages #1593

merged 5 commits into from
Jul 3, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Jul 2, 2024

What are you changing?

  • bumps typescript to v5.5.2 in the repo and updates all packages to use it
  • sets link-workspace-packages to true in .npmrc
  • sets bumpVersionsWithWorkspaceProtocolOnly to false in the changesets config
  • runs changesets version, capturing the changesets already in 🦋 Release package updates #1592 as well as these

Why?

  • to stay up to date with typescript
  • the package config changes should enable us to make the changes in a single pass
  • although pnpm is now set to install local copies of packages if they match the version required in a package.json, they still needed to be bumped so that typescript versions required in peerdeps matched the new version. doing this in a way that works with the release PR is impossible. so this PR contains both changes (the TS bump and the versionning)

@sndrs sndrs requested review from a team as code owners July 2, 2024 09:34
@sndrs sndrs requested a review from a team July 2, 2024 09:34
@sndrs sndrs requested review from a team as code owners July 2, 2024 09:34
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 279f298

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Jul 2, 2024
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sndrs sndrs marked this pull request as draft July 2, 2024 14:34
@sndrs sndrs marked this pull request as ready for review July 2, 2024 14:42
@sndrs sndrs requested a review from mxdvl July 2, 2024 14:42
@sndrs sndrs merged commit 44fd7be into main Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade TypeScript
3 participants