Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web typography presets to design tokens #1247

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Conversation

jamesmockett
Copy link
Contributor

@jamesmockett jamesmockett commented Feb 29, 2024

What are you changing?

Note

The new presets are not currently consumed or exposed anywhere so there is no change to Source Foundations. This will be done in a later PR.

Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: 8f128a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Feb 29, 2024
@jamesmockett jamesmockett changed the title Add typography presets to design tokens Add web typography presets to design tokens Feb 29, 2024
@jamesmockett jamesmockett self-assigned this Feb 29, 2024
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Feb 29, 2024
@jamesmockett jamesmockett linked an issue Feb 29, 2024 that may be closed by this pull request
@jamesmockett jamesmockett marked this pull request as ready for review February 29, 2024 15:38
@jamesmockett jamesmockett requested a review from a team as a code owner February 29, 2024 15:38
@jamesmockett jamesmockett merged commit 1b77501 into main Mar 6, 2024
20 checks passed
@jamesmockett jamesmockett deleted the jm/type-preset-tokens branch March 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add presets to tokens JSON
2 participants