feat: add new LocalStack AWS session via env var #1211
Conversation
blairham
changed the title
blairham
changed the title
blairham
changed the title
|
Hi, @zackproser or @denis256, or @brikis98. What does one need to do to get someone to take a look and approve or review the code and merge this? I took a look at the failing tests, and they are not related to these changes. |
| @@ -32,6 +33,21 @@ func NewAuthenticatedSession(region string) (*session.Session, error) { | |||
| func NewAuthenticatedSessionFromDefaultCredentials(region string) (*session.Session, error) { | |||
There was a problem hiding this comment.
Thanks for the PR! Could you please update the comment above this function to describe this behavior?
|
I had a look at the tests, and confirm that the failures indeed dont seem related to this PR. However, there isn't a test for the |
|
Yeah, I didn't see one either, let me take a crack at adding one. |
| awsSecretAccessKey = AWS_SECRET_ACCESS_KEY | ||
| } | ||
|
|
||
| awsConfig = awsConfig.WithEndpoint(localStackUrl).WithDisableSSL(true).WithCredentials(credentials.NewStaticCredentials(awsAccessKeyId, awsSecretAccessKey, "")) |
There was a problem hiding this comment.
Hi, will be helpful to have a test case to keep track that handling of TERRATEST_LOCALSTACK will continue to work
There was a problem hiding this comment.
unfortunately, that would require a lot more than you think as there aren't any tests for this for good reason. I don't think there is a reasonable way to invoke the auth to begin with
Description
Issues related
Pull Requests related
This adds a new create session that points to the URL specified in the env variable
TERRATEST_LOCALSTACK. Since we don't need any credentials with LocalStack, we assume some random credentials and use the rest of Terratest. This was inspired by @ffernandezcast PR and the comments in it. This should be a much simpler approach and much more maintainable, which was one of the questions made by @brikis98Usage
define the env var
TERRATEST_LOCALSTACKTODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for custom AWS Endpoint.