Cdrom misc #1023
Cdrom misc #1023
Conversation
Codecov ReportBase: 16.38% // Head: 16.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 16.38% 16.39% +0.01%
==========================================
Files 362 362
Lines 115768 115785 +17
==========================================
+ Hits 18971 18986 +15
- Misses 96797 96799 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/core/cdrom.cc
Outdated
| m_result[1] = 0; | ||
| m_result[2] = 0; | ||
| m_result[3] = 0; | ||
| memset((char *)&m_result[1], 0, 7); |
There was a problem hiding this comment.
Might be easier / safer to do the following:
memset(m_result, 0, sizeof(m_result);
m_result[0] = m_statP;| break; | ||
| } | ||
| } else { | ||
| IO<File> psxexe(reader.open("PSX.EXE;1")); | ||
| if (!psxexe->failed()) { | ||
| m_cdromId = "SLUS99999"; | ||
| exename = "PSX.EXE;1"; | ||
| m_bootable = true; |
There was a problem hiding this comment.
Maybe the check function should display a warning at the end that the disc isn't bootable in case this boolean is still false.
|
FWIW, asset discs exist on the PS1. They'll usually contain a dummy binary that displays a warning about the disc being a "DLC". For example, beatmania APPEND 3rdMIX. |
|
Superseded by #1129 Leaving branch/PR in-tact until the new code is mostly working. |
Fixing up some cdrom behavior around command responses. The main focus is currently around disc type detection and to avoid sending the license string for a non-bootable disc, though ideally this would not prevent reading from "unlicensed" discs, i.e. an asset CD when paired with a manually launched binary.