Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth.md #1355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update auth.md #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/en/docs/guides/auth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ and authorization in various languages.
| Python | [Python Example] | [Python Documentation] |


[Go Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/encryption
[Go Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/encryption#encryption
[Go Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication
[Go Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication#encryption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no #encryption section on the page, this link seems broken.

Comment on lines +216 to +217
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table is for language specific TLS examples. So the Go links seems to correctly point to the encryption directory. The table just below this is for OAuth examples, in which the Go row points to the links you've added in this PR.

grpc.io/content/en/docs/guides/auth.md

Lines 224 to 238 in f4a96fb

### Language guides and examples for OAuth token-based authentication
The following table links to examples demonstrating OAuth token-based
authentication and authorization in various languages.
| Language | Example | Documentation |
|----------|-------------------------------------------|-------------------------------|
| C++ | N/A | N/A |
| Go | [Go OAuth Example] | [Go OAuth Documentation] |
| Java | [Java OAuth Example] | [Java OAuth Documentation] |
| Python | [Python OAuth Example] | [Python OAuth Documentation] |
[Go OAuth Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication#authentication
[Go OAuth Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication#oauth2

[Java Example TLS]: https://github.com/grpc/grpc-java/tree/master/examples/example-tls
[Java Example ATLS]: https://github.com/grpc/grpc-java/tree/master/examples/example-alts
[Java Documentation]: https://github.com/grpc/grpc-java/tree/master/examples/example-tls#hello-world-example-with-tls
Expand Down