Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use #if directives to conditionally @preconcurrency import the Dispatch module to enable building the package on linux #1644

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

tayloraswift
Copy link
Contributor

see https://forums.swift.org/t/grdb-7-beta/75018/4

Pull Request Checklist

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

…ch module to enable building the package on linux
@groue
Copy link
Owner

groue commented Sep 30, 2024

Thank you @tayloraswift! Could you verify that these changes allow Swiftinit to build GRDB?

@tayloraswift
Copy link
Contributor Author

yes, i was able to build my fork here: https://swiftinit.org/hist/tayloraswift.grdb.swift:enable-linux-build/grdb

@groue groue merged commit fd04831 into groue:development Oct 6, 2024
8 checks passed
@groue
Copy link
Owner

groue commented Oct 6, 2024

Thank you! This will ship in the next beta :-)

@groue
Copy link
Owner

groue commented Oct 6, 2024

⛵ Shipped in 7.0.0-beta.3

@tayloraswift tayloraswift deleted the enable-linux-build branch October 7, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants