GRDB 7: enhance ergonomics of record methods that insert/save/upsert and fetch #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groue
force-pushed
the
dev/GRDB7-non-optional-fetch
branch
from
6f51092
to
39ed103
Compare
… return optionals. Those optionals were just an annoyance. Now, nil results are replaced with `RecordError.recordNotFound`. Such an error is only expected with the IGNORE conflict policy.
groue
force-pushed
the
dev/GRDB7-non-optional-fetch
branch
from
39ed103
to
cd4e853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
insertAndFetch,saveAndFetch, andupdateAndFetchmethods no longer return optionals.When inserts and updates are performed with the
IGNOREconflict policy, those methods can throwRecordError.recordNotFound(they used to return nil in case of conflict).