Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1479 - Add Privacy manifest file #1480

Closed
wants to merge 1 commit into from
Closed

Issue #1479 - Add Privacy manifest file #1480

wants to merge 1 commit into from

Conversation

giobass
Copy link

@giobass giobass commented Jan 9, 2024

This pull request include a Privacy manifest file as discussed in Issue #1479.
I went throught the whole codebase and i didn't find any of the restricted APIs usage

@groue
Copy link
Owner

groue commented Jan 13, 2024

Hello @giobass,

Thank you for this pull request and looking for restricted APIs.

It looks like SPM support is not correctly done:

> swift build
...
warning: 'grdb.swift': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target

You can also open Package.swift in Xcode, and you have a nice warning:

Invalid Resource 'GRDB/PrivacyInfo.xcprivacy': File not found.

In other words, the validity of the proposed changes were not checked 😕

I'm generally happy to spend time guiding contributors towards a successful merge, but the basic threshold that would raise my interest and establish my trust has not been crossed. I close the pull request and I am not asking for a better one. EDIT: Apologies for my bad initial wording: I have a problem with the quality of the pull request, not with you, personally.

BTW, when the pull request was opened, you were presented with the pull request template. I suggest taking care of it in any future contribution, in GRDB or in any other repository that provides such a guidance.

Thank you,

cc @danielepantaleone

@groue groue closed this Jan 13, 2024
@groue groue added the invalid or off-topic Not about GRDB, or does not contain any useful information label Jan 13, 2024
@danielepantaleone danielepantaleone mentioned this pull request Feb 15, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid or off-topic Not about GRDB, or does not contain any useful information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants