Remove shadow tables from database dump #1477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1464 by not recording shadow tables from
dumpContent(format:to:)
.Shadow tables are implementation details of virtual tables (FTS4, FTS5, ...) that do not provide useful information in database dumps.
Caveat: detection of shadow tables uses PRAGMA table_list and requires SQLite 3.37+ (iOS 15.4, macOS 12.4, tvOS 15.4, watchOS 8.5). When run with older SQLite versions, shadow tables are still recorded.
This might bother applications that use the GRDBSnapshotTesting companion library, because the test results change, depending on the SQLite version 😬
A possible solution is to skip those tests until SQLite 3.37+, as in the sample code below: