Release 2.2.2

[Altonss]

Here are the steps to follow when preparing a new release. Please check the following boxes with an x when done:

• update PTE to the latest commit at opentransitmap and run ./update-dependency-pinning.sh
• test the app (automatically using AndroidTest as well as manually), paying special attention to changes since the last release
• fix any bugs if necessary
• [ ] update translations from Transifex using tx pull --mode=developer -a in the root folder (you need proper permissions to do that) (I'm not sure I have the permissions, and it's probably not really usefull)
• [ ] add newly supported languages to the two arrays in app/src/main/res/values/arrays.xml
• revise the commits to master since the last release and add interesting changes (as well as new languages) to the changelog at app/src/main/res/xml/changelog_master.xml, then run python3 ./fastlane/generate_changelog.py
• bump the versionCode and versionName in app/build.gradle
• file another PR updating all dependencies which should be merged after the successful release

This release will fix #960

[Altonss]

This is somewhat weird, everything is building fine locally with Android Studio 🤔
Edit: found the issue, PARIS network id was still used in ScreengrabTest.kt.

[grote]

Thanks!

everything is building fine locally with Android Studio

That's what CI is for ;) You rarely test everything locally.

[grote]

@Altonss want me to push out this release? Did you test it? Also on clean install?

[Altonss]

@Altonss want me to push out this release? Did you test it? Also on clean install?

It works fine for me on Android 5 emulator, and Android 13 device (clean Transportr Devel install). Tested and works well on DB, CH, BVG & MVV networks. Doesn't work on TransportNSW (Australia), but this problem isn't new (also broken on 2.2.1).
Just to be extra cautious you can test it too (if you have the time), but otherwise I think this release could be pushed out soon :)

[grote]

Should be released now: https://github.com/grote/Transportr/releases/tag/2.2.2
Also on Google Play (in beta for now). Let me know once it should be stable there. Maybe we release to stable right away in the future.

[Altonss]

Also on Google Play (in beta for now). Let me know once it should be stable there. Maybe we release to stable right away in the future.

@grote let's keep it beta for now. There seems to be a crash on Android 14, see #972, I cannot reproduce on Android 14 emulator :/ Maybe the best is to keep in beta, and also disable this build on F-Droid so it doesn't get pushed out other then GPlay beta while we investigate the bug?

[grote]

Exception java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$4.done (AsyncTask.java:415)
at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:381)
at java.util.concurrent.FutureTask.setException (FutureTask.java:250)
at java.util.concurrent.FutureTask.run (FutureTask.java:269)
at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:305)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:644)
at java.lang.Thread.run (Thread.java:1012)
Caused by java.lang.NoClassDefFoundError: Failed resolution of: Lorg/slf4j/LoggerFactory;
at de.schildbach.pte.AbstractEfaProvider. (AbstractEfaProvider.java:128)
at de.grobox.transportr.networks.TransportNetworksKt$networks$49.invoke (TransportNetworks.kt:473)
at de.grobox.transportr.networks.TransportNetworksKt$networks$49.invoke (TransportNetworks.kt:467)
at de.grobox.transportr.networks.TransportNetwork.getNetworkProviderReference (TransportNetwork.kt:51)
at de.grobox.transportr.networks.TransportNetwork.access$getNetworkProviderReference (TransportNetwork.kt:32)
at de.grobox.transportr.networks.TransportNetwork$networkProviderRef$2.invoke (TransportNetwork.kt:50)
at de.grobox.transportr.networks.TransportNetwork$networkProviderRef$2.invoke (TransportNetwork.kt:50)
at kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74)
at de.grobox.transportr.networks.TransportNetwork.getNetworkProviderRef (TransportNetwork.kt:50)
at de.grobox.transportr.networks.TransportNetwork.access$getNetworkProviderRef (TransportNetwork.kt:32)
at de.grobox.transportr.networks.TransportNetwork$networkProvider$2.invoke (TransportNetwork.kt:49)
at de.grobox.transportr.networks.TransportNetwork$networkProvider$2.invoke (TransportNetwork.kt:49)
at kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74)
at de.grobox.transportr.networks.TransportNetwork.getNetworkProvider (TransportNetwork.kt:49)
at de.grobox.transportr.locations.SuggestLocationsTask.doInBackground (SuggestLocationsTask.java:48)
at de.grobox.transportr.locations.SuggestLocationsTask.doInBackground (SuggestLocationsTask.java:31)
at android.os.AsyncTask$3.call (AsyncTask.java:394)
at java.util.concurrent.FutureTask.run (FutureTask.java:264)
Caused by java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
... 22 more

[grote]

Exception java.lang.IllegalArgumentException: Null Island is not a valid location
at com.google.common.base.Preconditions.checkArgument (Preconditions.java:142)
at de.grobox.transportr.locations.WrapLocation. (WrapLocation.java:83)
at de.grobox.transportr.map.MapFragment.onMapReady$lambda-2 (MapFragment.kt:85)
at de.grobox.transportr.map.MapFragment.$r8$lambda$exyFJqOeheih09aw6sUfZ0WbcVI (MapFragment.kt)
at de.grobox.transportr.map.MapFragment$$ExternalSyntheticLambda1.onMapLongClick (R8$$SyntheticClass)
at com.mapbox.mapboxsdk.maps.MapGestureDetector.notifyOnMapLongClickListeners (MapGestureDetector.java:1008)
at com.mapbox.mapboxsdk.maps.MapGestureDetector$StandardGestureListener.onLongPress (MapGestureDetector.java:404)
at com.mapbox.android.gestures.StandardGestureDetector$1.onLongPress (StandardGestureDetector.java:45)
at android.view.GestureDetector.dispatchLongPress (GestureDetector.java:886)
at android.view.GestureDetector.access$300 (GestureDetector.java:55)
at android.view.GestureDetector$GestureHandler.handleMessage (GestureDetector.java:320)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loopOnce (Looper.java:201)
at android.os.Looper.loop (Looper.java:288)
at android.app.ActivityThread.main (ActivityThread.java:7870)
at java.lang.reflect.Method.invoke
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)

[Altonss]

Exception java.lang.RuntimeException: An error occurred while executing doInBackground() at android.os.AsyncTask$4.done (AsyncTask.java:415) at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:381) at java.util.concurrent.FutureTask.setException (FutureTask.java:250) at java.util.concurrent.FutureTask.run (FutureTask.java:269) at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:305) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:644) at java.lang.Thread.run (Thread.java:1012) Caused by java.lang.NoClassDefFoundError: Failed resolution of: Lorg/slf4j/LoggerFactory; at de.schildbach.pte.AbstractEfaProvider. (AbstractEfaProvider.java:128) at de.grobox.transportr.networks.TransportNetworksKt$networks$49.invoke (TransportNetworks.kt:473) at de.grobox.transportr.networks.TransportNetworksKt$networks$49.invoke (TransportNetworks.kt:467) at de.grobox.transportr.networks.TransportNetwork.getNetworkProviderReference (TransportNetwork.kt:51) at de.grobox.transportr.networks.TransportNetwork.access$getNetworkProviderReference (TransportNetwork.kt:32) at de.grobox.transportr.networks.TransportNetwork$networkProviderRef$2.invoke (TransportNetwork.kt:50) at de.grobox.transportr.networks.TransportNetwork$networkProviderRef$2.invoke (TransportNetwork.kt:50) at kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74) at de.grobox.transportr.networks.TransportNetwork.getNetworkProviderRef (TransportNetwork.kt:50) at de.grobox.transportr.networks.TransportNetwork.access$getNetworkProviderRef (TransportNetwork.kt:32) at de.grobox.transportr.networks.TransportNetwork$networkProvider$2.invoke (TransportNetwork.kt:49) at de.grobox.transportr.networks.TransportNetwork$networkProvider$2.invoke (TransportNetwork.kt:49) at kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74) at de.grobox.transportr.networks.TransportNetwork.getNetworkProvider (TransportNetwork.kt:49) at de.grobox.transportr.locations.SuggestLocationsTask.doInBackground (SuggestLocationsTask.java:48) at de.grobox.transportr.locations.SuggestLocationsTask.doInBackground (SuggestLocationsTask.java:31) at android.os.AsyncTask$3.call (AsyncTask.java:394) at java.util.concurrent.FutureTask.run (FutureTask.java:264) Caused by java.lang.ClassNotFoundException: org.slf4j.LoggerFactory ... 22 more

Indeed that's what has been raised #972. I think I already have a fix for this (probably due to difference between the debug build and the release build).

[grote]

Always good to test the release build ;)

[Altonss]

Always good to test the release build ;)

Indeed, sorry for the oversight :/ (But it's a bit of a pain to make in work Android Studio ^^ by setting up a new fake release key, and I would have thought the CI is also testing the release build).

Anyway, I'll test the fix for both release and debug build this time :)

[Altonss]

Exception java.lang.IllegalArgumentException: Null Island is not a valid location at com.google.common.base.Preconditions.checkArgument (Preconditions.java:142) at de.grobox.transportr.locations.WrapLocation. (WrapLocation.java:83) at de.grobox.transportr.map.MapFragment.onMapReady$lambda-2 (MapFragment.kt:85) at de.grobox.transportr.map.MapFragment.$r8$lambda$exyFJqOeheih09aw6sUfZ0WbcVI (MapFragment.kt) at de.grobox.transportr.map.MapFragment$$ExternalSyntheticLambda1.onMapLongClick (R8$$SyntheticClass) at com.mapbox.mapboxsdk.maps.MapGestureDetector.notifyOnMapLongClickListeners (MapGestureDetector.java:1008) at com.mapbox.mapboxsdk.maps.MapGestureDetector$StandardGestureListener.onLongPress (MapGestureDetector.java:404) at com.mapbox.android.gestures.StandardGestureDetector$1.onLongPress (StandardGestureDetector.java:45) at android.view.GestureDetector.dispatchLongPress (GestureDetector.java:886) at android.view.GestureDetector.access$300 (GestureDetector.java:55) at android.view.GestureDetector$GestureHandler.handleMessage (GestureDetector.java:320) at android.os.Handler.dispatchMessage (Handler.java:106) at android.os.Looper.loopOnce (Looper.java:201) at android.os.Looper.loop (Looper.java:288) at android.app.ActivityThread.main (ActivityThread.java:7870) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)

Is this a separate bug not related to slf4j or just the continuation of the stack trace?

[grote]

No fake key needed, just make a new "test key" and do this: https://github.com/grote/Transportr/blob/master/app/build.gradle#L67

then you can always use that to make release builds.

[grote]

Is this a separate bug not related to slf4j or just the continuation of the stack trace?

separate bug it seems. I just pasted the stacktraces from google play here.

[Altonss]

@grote Pushed the small fix to master (wanted to do it through a PR, but inadvertadly pushed directly in github web ui, sorry for that :/ )

[grote]

if nobody is there to review your stuff, feel free to push to master directly, faster this way. let me know when you want a new release. I paused beta track on google play.