-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.0 #888
Release 2.2.0 #888
Conversation
several issues reported: #889 #890 https://gitlab.com/opentransitmap/public-transport-enabler/-/issues/6 In order to get the release out soon, I'd consider them as being non-release-blocking. |
Indeed, #889 and #890 don't seem to be new issues related to this release. |
Could #872 be a part of this release as well? |
Tested this 2.2.0 release branch, and didn't encounter any issue! Great job @ialokim 👏 |
For the changelog I suggest something like:
|
@ialokim any way i can help to get this release done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work @ialokim! Everything looks fine to me!
A few general comments (aside from those in the code):
- Why updating strings for pl network navitia that is for now removed? IMHO it clutters a bit the PR with useless strings.
- Should we merge Fix potential UI glitch when transport type is not given #894 before 2.2.0 ? Edit: Let's do it after :)
- Shouldn't we also mention in the changelogs that we've re-added VRS?
- Encountered an unrelated issue (is already present in 2.1.5): background color of changelog is dark when in light mode. (Opened Background color of changelog is dark when in light mode. #909)
<release | ||
version="2.2.0" | ||
versioncode="124"> | ||
<change>Switch map library to MapLibre - finally bringing Transportr back to F-Droid!</change> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, we didn't make it back, yet ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's the next unchecked bullet point in the first post, but we cannot continue without tagging the release :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we will make it back (I hope)! 😄
Thanks for your review @Altonss!
There are a lot of leftover strings from now removed regions which should probably be cleaned properly at some point. But you are right, those are unfortunately really useless. I've removed them now manually.
Good catch, added that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Ready to merge and tag the release? |
Thanks everyone who contributed to this release. You are awesome! :D I just pressed the button and the release is out. However, Google Play doesn't accept it: |
That shouldn't be too hard to fix, I'll try to do it :) |
Here are the steps to follow when preparing a new release (some custom tasks added for this release). Please check the following boxes with an
x
when done:./update-dependency-pinning.sh
re-enable PL (Poland) with new data source https://gitlab.com/opentransitmap/public-transport-enabler/-/commit/693d84e340f1525366e6b29a32c0a81401f326ff(needs more investigation as to which area is actually covered)tx pull --mode=developer -a
in the root folder (you need proper permissions to do that)app/src/main/res/values/arrays.xml
master
since the last release and add interesting changes (as well as new languages) to the changelog atapp/src/main/res/xml/changelog_master.xml
, then runpython3 ./fastlane/generate_changelog.py
versionCode
andversionName
inapp/build.gradle
Please also refer to #689 as an example.