Update libraries and translations, fix some lint errors #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed ✔️
grote
reviewed
Sep 14, 2020
| implementation 'androidx.appcompat:appcompat:1.2.0' | ||
| implementation 'androidx.activity:activity:1.1.0' | ||
| implementation('androidx.fragment:fragment:1.1.0!!') { | ||
| because 'issues with MapBox SDK onDestroy after upgrading to 1.2.0-alpha02 or newer versions' |
There was a problem hiding this comment.
Hopefully, this won't cause issues with other AndroidX libraries depending on this one.
| exclude group: 'com.android.support', module: 'support-annotations' | ||
| exclude group: 'com.android.support.test.uiautomator' | ||
| exclude group: 'com.google.code.findbugs' | ||
| exclude group: 'androidx.test.uiautomator' //requires minSDK >= 18 |
There was a problem hiding this comment.
If needed, one could take a use minSDK for instrumentation tests only.
|
Crazy that lint hangs for 10min, btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #689.