-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added collapse long trip warning messages #524
base: master
Are you sure you want to change the base?
Conversation
app/src/main/java/de/grobox/transportr/departures/DepartureViewHolder.java
Outdated
Show resolved
Hide resolved
@TheLastProject fixed unintentional tabs to spaces |
@anjandev thanks a lot for the PR! Are these "Expand" links always shown, or only when the text exceeds a certain lenght? |
</attr> | ||
</declare-styleable> | ||
|
||
</resources> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add this? I don't really understand the chinese on the libraries' page.
Torsten Grote <[email protected]> writes:
@anjandev thanks a lot for the PR!
No problem. Thank you for reviewing.
Are these "Expand" links always shown, or only when the text exceeds a certain lenght?
Expand is only shown when text exceeds a certain length.
See:
https://user-images.githubusercontent.com/8602360/46909957-af371980-cf2a-11e8-926d-e9cf8cf58eee.png
Why do we need to add this? I don't really understand the chinese on the libraries' page.
I dont understand chinese either but this was the only library I could
make work. Furthermore, this library allows us to have the simpliest
code.
I deleted the attr file and the code compiles and runs fine. I just made
a new commit deleting the attr file.
Thanks for the feedback.
|
@grote Is there any reason this was never merged and is there anything I can do to get it into a state that can be merged? |
Where does the What happens if some notices are expanded and some or not and you rotate the screen? Does this library maintain the expanded state across configuration changes? |
Uses library: https://github.com/Carbs0126/ExpandableTextView
This gif was made with commit 09f451a (test code).
Test code was then removed with commit: 39f4f0f.
Fixes issue #422.