Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fdroid release #826

Closed
leg7 opened this issue Aug 15, 2022 · 38 comments
Closed

Update fdroid release #826

leg7 opened this issue Aug 15, 2022 · 38 comments
Labels
bug 🐞 A functional defect or unexpected behavior. priority 🚨️ This issue will be most probably addressed before the next release.

Comments

@leg7
Copy link

leg7 commented Aug 15, 2022

The last fdroid release was 4 years ago and even using the custom repository in the readme doesn't fix this.

Can the fdroid version be updated?

@leg7 leg7 added the bug 🐞 A functional defect or unexpected behavior. label Aug 15, 2022
@calve
Copy link

calve commented Aug 15, 2022

fwiw, Fdroid downgraded Transportr release to an old one not depending on (I guess) Google Map;

read at https://gitlab.com/fdroid/fdroidserver/-/issues/1004#note_1030833616 and https://gitlab.com/fdroid/fdroiddata/-/commit/dd848d73572928408ea85f8e0498ec0a3dcb8aec thus I'm not involved in this in any way.

@julianfairfax
Copy link

This is the supposed solution: https://gitlab.com/fdroid/fdroidserver/-/issues/1004#note_1036153553

@leg7
Copy link
Author

leg7 commented Aug 16, 2022

So from what I got a solution is being worked on to replace the google maps dependency with maplibre?

Is google maps a proprietary blob included in the apk or is transportr just using the api? Would it be feasible to get rid of the proprietary dependency upstream?

@julianfairfax
Copy link

So from what I got a solution is being worked on to replace the google maps dependency with maplibre?

I don't know if it's being worked on but it has been suggested.

Is google maps a proprietary blob included in the apk or is transportr just using the api? Would it be feasible to get rid of the proprietary dependency upstream?

Mapbox is dragging it in. I suppose it would be possible to fix that upstream, but if switching to MapLibre works, that's probably a better solution.

@ialokim
Copy link
Collaborator

ialokim commented Aug 16, 2022

Yes, we're aiming to switching to MapLibre since new versions of Mapbox itself ar not compatible with free software anymore. Still default MapLibre currently has the same problem of depending on proprietary parts at compile time, which is not accepted by F-Droid. See the upstream issue at maplibre/maplibre-native#379 and #668 for our part, switching to MapLibre.

@ialokim ialokim added the priority 🚨️ This issue will be most probably addressed before the next release. label Aug 16, 2022
@jakoblm
Copy link

jakoblm commented Sep 18, 2022

The issue has now been pushed again in the MapLibre repo: maplibre/maplibre-native#379

@jakoblm
Copy link

jakoblm commented Sep 21, 2022

How about Transportr switching to the alternative AnyMaps (https://github.com/johan12345/AnyMaps) or osmdroid (https://github.com/osmdroid/osmdroid)? Obviously both use only free software and are accepted by F-Droid without any problems. See the following comment: maplibre/maplibre-native#379 (comment)

@1Maxnet1
Copy link

1Maxnet1 commented Oct 1, 2022

A short time workaround would be to offer stable releases over a third party repository (e.g. https://android.izzysoft.de/repo/info offers to include apps in his repository). This would enable users to add the repository and use a more modern app version.

@julianfairfax
Copy link

A short time workaround would be to offer stable releases over a third party repository (e.g. https://android.izzysoft.de/repo/info offers to include apps in his repository). This would enable users to add the repository and use a more modern app version.

I could host it on my repo, which would be updated from their GitHub releases every 24 hours, or they could copy mine to host it on GitHub pages themselves.

@ialokim
Copy link
Collaborator

ialokim commented Oct 2, 2022

How about Transportr switching to the alternative AnyMaps (https://github.com/johan12345/AnyMaps) or osmdroid (https://github.com/osmdroid/osmdroid)? Obviously both use only free software and are accepted by F-Droid without any problems. See the following comment: maplibre/maplibre-gl-native#379 (comment)

@jakoblm AnyMaps is just a wrapper over MapLibre with different API and osmdroid is a completely different kind of thing based on raster tile maps instead of vector maps. It is not realistic to change the API or even the complete map library just because of this issue which should be fixable upstream at MapLibre.

@ialokim
Copy link
Collaborator

ialokim commented Oct 2, 2022

A short time workaround would be to offer stable releases over a third party repository (e.g. https://android.izzysoft.de/repo/info offers to include apps in his repository). This would enable users to add the repository and use a more modern app version.

This is actually a good idea, maybe @IzzySoft could tell us what he'd need from us? (I'd prefer his repo over another private one since it is probably more likely that people have it added to their F-Droid client already.)

Perhaps we should also disable Transportr on the F-Droid repo completely until we fixed the issue to avoid having people installing outdated versions like #831.

@IzzySoft
Copy link

IzzySoft commented Oct 3, 2022

Everything needed is in place, so I've just added Transportr to my repo as requested (effective with the next sync around 6 pm UTC).

@starsforeveryone
Copy link

I strongly advise that F-Droid is continued to be supported, and the newest version can be found there without any third party repositories.

The whole point of Transportr was to create a FOSS (free and open source software) app. F-Droid symbolizes this very idea of supporting freedom and privacy. I believe the author of Transportr shares these values. We already have a world-wide map created by nerds from around the world in their free time, Open Street Map, which would be an excellent replacement. What would be the point of these nerds doing this job for the past 18 years when we then don't use it and stick with Google instead? We're better than that.

Therefore, we should get rid of Google Maps and replace it with Open Street Map through osmdroid. :)

@IzzySoft
Copy link

IzzySoft commented Oct 3, 2022

@starsforeveryone that's known and being worked on. The culprit is a dependency of a dependency (see here: it's not Google Maps but Mapbox being used as a wrapper for the map backend, but Mapbox unfortunately depends on GMS for location), and a replacement needs to be implemented (e.g. maplibre). As pointed out by @1Maxnet1 the listing in my repo is intended as a temporary work-around until the issue is solved (though I'd have no problems with keeping Transportr in my repo if that is wanted).

@starsforeveryone
Copy link

Thanks for clearing that up! :)

@David-Else
Copy link

I just heard about this software, went to install it from Fdroid, and to my horror found it looked like abandon-ware! I nearly gave up, but spent the extra time to research and came to this thread. I am sure 90% of people would not have bothered.

Will a proper version be coming to Fdroid this year, or should I look for other software? Cheers.

@jakoblm
Copy link

jakoblm commented Nov 6, 2022

At the moment, that depends on whether a solution is found in Maplibre that meets the specifications at F-Droid.
The Maplibre team has now asked for help to find a good solution soon. Wouldn't some experts from Transportr be willing to cooperate with Maplibre? See details here: maplibre/maplibre-native#379 (comment)

@kudlav
Copy link

kudlav commented Feb 13, 2023

Maplibre will remove the dep of GMS soon. See
maplibre/maplibre-native#801

@genofire
Copy link

genofire commented Feb 15, 2023

Now landed in version 10.0.0 - here the documentation for migration in Transportr:
https://github.com/maplibre/maplibre-gl-native/blob/main/platform/android/CHANGELOG.md#1000---february-15-2023

@mnalis
Copy link

mnalis commented Mar 10, 2023

So, now that new Maplibre (which no longer depends on non-free GMS) has been released, we need to wait for new version of Transportr to upgrade to it, and then it might be included in f-droid again?

@Altonss
Copy link
Collaborator

Altonss commented Mar 10, 2023

So, now that new Maplibre (which no longer depends on non-free GMS) has been released, we need to wait for new version of Transportr to upgrade to it, and then it might be included in f-droid again?

Yes a new version of Transportr needs to be published (integrating Maplibre instead of Mapbox) for this newest version to appear in F-Droid (Transportr is still included in F-Droid, but sadly only a very old version).

@tuxayo
Copy link

tuxayo commented Mar 11, 2023

a new version of Transportr needs to be published

And developed ^^"

By any chance, has anyone taken a first look at how much work could it be for the switch? Hopefully the Mapbox version of Transportr isn't too old, otherwise there would also be additional upgrade work.

@Altonss
Copy link
Collaborator

Altonss commented Mar 11, 2023

a new version of Transportr needs to be published

And developed ^^"

By any chance, has anyone taken a first look at how much work could it be for the switch? Hopefully the Mapbox version of Transportr isn't too old, otherwise there would also be additional upgrade work.

A lot of work has already been done by @ialokim on this branch: https://github.com/grote/Transportr/tree/maplibre

@genofire
Copy link

No pressure, but is there any update?

@leg7
Copy link
Author

leg7 commented May 15, 2023

No pressure, but is there any update?

I tried building the latest maplibre branch revision (29fbd55) from source with termux but the build fails. Someone needs finish the migration. I can give it a shot next week after my finals if it's not too complicated as I know nothing about this codebase or maplibre.

@Altonss
Copy link
Collaborator

Altonss commented May 19, 2023

No pressure, but is there any update?

I tried building the latest maplibre branch revision (29fbd55) from source with termux but the build fails. Someone needs finish the migration. I can give it a shot next week after my finals if it's not too complicated as I know nothing about this codebase or maplibre.

When I last tried, I was able to build the maplibre branch of @ialokim without an issue on Android Studio

@Jowat97
Copy link

Jowat97 commented Sep 18, 2023

As far as I can tell, there is already a pull request to fix this issue: #880
Is there anything from preventing this or is any further help needed? Please feel free to ask. It would be amazing to have this app back on F-Droid.

@ialokim
Copy link
Collaborator

ialokim commented Oct 6, 2023

Even the old versions of Transportr are now disabled: https://gitlab.com/fdroid/fdroiddata/-/commit/0b38fbe548cfa419ec3c94c1286baaf9eec031b6

Indeed, the PR to bring us back to F-Droid is already in the pipeline: #880

@omnivagant
Copy link

Apparently I've been using an old version without really realizing, happy that f-droid doesn't remove disabled apps. I noticed because I wanted to suggest the app to some friends and went into the f-droid app to fetch an f-droid link and just couldn't find it.

This map function seems very neat, although I've never felt that I've missed it, I will probably use it when an updated version is available in the f-droid repo again.

However, is it possible to disable this map function and/or would it work with offline maps? I did see #126 and understand why offline traffic planning would be hard, but at least map data shouldn't have to be fetched if maps are already downloaded.

This also brings me to an even less related issue, that the varoius offline map apps don't share map data so you often need duplicates if you switch beetween map apps, say OsmAnd~ and Organic Maps.

Anyways, thank you for a very useful app even when several years out of date.

@Altonss
Copy link
Collaborator

Altonss commented Oct 23, 2023

However, is it possible to disable this map function and/or would it work with offline maps? I did see #126 and understand why offline traffic planning would be hard, but at least map data shouldn't have to be fetched if maps are already downloaded.

There is an issue about optional map here : #504

@licaon-kter
Copy link

https://gitlab.com/fdroid/fdroiddata/-/commit/c47b332f453092521ef1d38ae0a9bb065da2d0f0

/close this :)

@Altonss
Copy link
Collaborator

Altonss commented Jan 11, 2024

So no more Mapbox issue detected? 🎉
Thanks a lot @licaon-kter!
(I'll close once the package is available on F-Droid)

@rugk
Copy link

rugk commented Jan 14, 2024

Its on F-Droid is not it?

@rugk
Copy link

rugk commented Jan 14, 2024

No I mean, I already saw it. Updated 4 days ago.

@ialokim
Copy link
Collaborator

ialokim commented Jan 14, 2024

No I mean, I already saw it. Updated 4 days ago.

Yes, but this is from IzzyOnDroid's repo that has less strict inclusion criteria: https://apt.izzysoft.de/fdroid/index/apk/de.grobox.liberario We've added Transportr there when it got excluded from F-Droid's main repo.

Good news though: Transportr has already been built successfully during the current F-Droid build run: https://monitor.f-droid.org/builds/log/de.grobox.liberario/124#site-footer

@Altonss
Copy link
Collaborator

Altonss commented Jan 16, 2024

It is available now :)

@Altonss Altonss closed this as completed Jan 16, 2024
@IzzySoft
Copy link

IzzySoft commented Dec 4, 2024

@julianfairfax @ialokim @Altonss as "since back then" Transportr is also available at IzzyOnDroid, maybe you want to pick a badge and link there, next to the other two? At IzzyOnDroid it's even confirmed as RB 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 A functional defect or unexpected behavior. priority 🚨️ This issue will be most probably addressed before the next release.
Projects
None yet
Development

No branches or pull requests