ci, cd: merge #2689
Open
ci, cd: merge #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale:
This will make testing PRs easier for other people as the builds
will always be present but the main reason for this change is to
merge the CI and CD.
Rationale:
Since the CI uploads artifacts now, there's no need for a separate
CD.
Rationale:
So that installer packages are also included in the artifacts.
Rationale:
The @abs_top_srcdir@ for CHANGELOG.md in share/setup.nsi.in points
to the build dir when building in a distdir.
Rationale:
Moving the installer is not optimal as Make expects the file to be
in the specified path of the rule in order to decide on whether to
re-create the file or not. This also breaks the CI's artifact code
as it expects the file to be present in the same way.
Rationale:
Same as the previous commit.
barton2526
reviewed
Jun 1, 2023
| export GRIDCOIN_CONFIG="--enable-reduce-exports" | ||
| export DEP_OPTS="NO_QT=1" |
There was a problem hiding this comment.
is there a reason for this change?
There was a problem hiding this comment.
The artifacts should contain the Qt builds as CI is overloaded to be used for releases?
|
Does this need to be tweaked now that we merged the cmake PR? |
|
No, unless we want to expose artifacts from the CMake CI as well. This PR is mainly done to reduce the maintenance burden of the CD for which the artifacts from the CI are enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CI to upload the created artifacts and removes the cd system. The created artifacts can be downloaded from the bottom of the job page. (See: https://github.com/div72/Gridcoin-Research/actions/runs/5085626106 for an example)
Upsides:
Downsides:
This PR also changes the output directories for some release files. See the relevant commit messages for the rationale.