Support dialogfragment #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update your travis-ci to have build tools 23.0.3? |
| @@ -6,5 +6,5 @@ | |||
| <string name="permission_granted">Permission Granted!</string> | |||
| <string name="permission_permanently_denied">Permission Permanently Denied.</string> | |||
| <string name="permission_denied">Permission Denied.</string> | |||
| <string name="two_permission_granted">2 Permissions Granted.</string> | |||
| <string name="X_permissions_granted">%1$d Permissions Granted.</string> | |||
|
Hey, just like on your other PR, I didn't see that you merged in master and got the build working. I'm going to look into this PR in more depth later tonight and test it out. Thanks so much for taking the time to contribute! |
|
PR looks good! Just merge in master so I can see the true diff, and we should be good from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fixes for #13 and #2.