Add support for table #56
Conversation
|
Oh, wow, thank you very much. This is a significant PR. I'm going to need a little time to review it, but will try to do so today or over the weekend. |
| @@ -948,7 +1126,8 @@ | |||
| (define $list (<or> $ordered-list $bullet-list)) | |||
|
|
|||
| (define $block | |||
| (<?> (<or> $atx-heading | |||
| (<?> (<or> $table | |||
There was a problem hiding this comment.
I think this should be (unless-strict $table). Like for instance (unless-strict $verbatim/fenced) and other items in this list which add features not in the original markdown description. In other words if a user of the library sets current-strict-markdown? to #t, then tables should not be parsed.
|
Take your time to review, i am unsure of $table-cell many rule should be rewrite to stop fail on #\newline and on #| when it make sense. Also check #57 |
As for |
|
Already implemented something, the idea is to parse everything expect #\newline #| (and special char) then reparse the result with a another parser. |
|
I left a few comments. I might have a few more. Maybe we should touch base on the overall strategy.
I'm happy to proceed either way. It depends on your preference and how much time you want to spend on this. Either way, I really appreciate your contribution. This is awesome. Thank you so much! |
Add a condition to make table parsing unavailable in strict markdown. Trim whitespace in table cell parse result. Reuse the $inline parser to parse table cell.
|
I have applied your suggestions and agree with them. |
Thanks!
Ah, I misunderstood. |
|
Ok, made the changes and the unit test remain clear, so a good code removing. |
|
Thanks! I'm excited to look at it, but unfortunately might not be able
to for a few days.
|
Adds support for tables from greghendershott/markdown#56
No description provided.