Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept HTML produced from #lang scribble/base #141

Merged

Conversation

khinsen
Copy link
Contributor

@khinsen khinsen commented Jul 20, 2015

A minor convience for those who, like me, have the habit of using #lang scribble/base for writing future HTML.

@greghendershott
Copy link
Owner

This looks good. I'd merge, but I'm frustrated (not with you!) about the 5.3.x build jobs failing on Travis:

$ raco pkg install --deps search-auto --link frog
The following packages are listed as dependencies, but are not currently installed,
so they will be automatically installed:
    base html-lib racket-index scribble-lib srfi-lite-lib web-server-lib markdown rackjure find-parent-dir 
package-url->checksum: Could not connect to GitHub
  context...:
   /home/travis/racket/collects/pkg/util.rkt:50:0: package-url->checksum11
   /home/travis/racket/collects/pkg/lib.rkt:459:2: install-package228
   /home/travis/racket/collects/pkg/lib.rkt:459:2: install-package228
   /home/travis/racket/collects/pkg/lib.rkt:981:4: for-loop
   /home/travis/racket/collects/pkg/lib.rkt:449:0: install-packages55
   /home/travis/racket/collects/racket/file.rkt:295:8
   /home/travis/racket/collects/racket/file.rkt:284:0: call-with-file-lock24
   /home/travis/racket/collects/pkg/main.rkt: [running body]
   /home/travis/racket/collects/pkg/raco.rkt: [traversing imports]
   /home/travis/racket/collects/raco/raco.rkt: [running body]
   /home/travis/racket/collects/raco/main.rkt: [running body]

I've seen that happen rarely; restarting the job always fixes it.

But I've restarted it a couple times and it's still failing there.

Is Racket 5.3.x using the GitHub API in a slightly wrong way, that no longer works? Unfortunately I'm time-limited to chase this down today. If you can figure out more, great, otherwise I'll try to tackle it later.

(We could just drop support for Racket 5.3.5 and 5.3.6. But aside from today's glitch, there's no reason not to keep supporting them.)

@greghendershott greghendershott self-assigned this Jul 20, 2015
@greghendershott greghendershott merged commit 258b396 into greghendershott:master Jul 20, 2015
@greghendershott
Copy link
Owner

From #racket and looking at code I determined it's failing b/c Racket 5.3.x doesn't supply creds to the GitHub API, and that API is rate-limited.

I did eventually get a restart of the Racket 5.3.5 job to pass. Although not yet 5.3.6, from what the code changes I think it's fine.

So: Merged. Thanks!

@greghendershott
Copy link
Owner

FWIW I logged the general issue: greghendershott/travis-racket#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants