Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split general content (intro, discussion) across sections #735

Merged
merged 5 commits into from
Dec 21, 2020

Conversation

rando2
Copy link
Contributor

@rando2 rando2 commented Nov 30, 2020

Description of the proposed additions or changes

This is a general proposal of how to move around the material from the intro and discussion. It is not incorporated very fluidly into the new locations in this PR, but I think separating these processes out will make it a lot easier to track the history of who worked on what!

Related issues

This is rebased on top of #734, so should not be merged until after that one is. Right now the changes proposed in #734 are also proposed here. I'm marking it as a draft to make sure there is no issue.

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

@rando2 rando2 marked this pull request as draft November 30, 2020 22:59
@agitter
Copy link
Collaborator

agitter commented Nov 30, 2020

I think separating these processes out will make it a lot easier to track the history of who worked on what!

I definitely agree with this. One round of pull requests can remap existing content into files. Then a separate round of pull requests can rephrase and edit as needed.

@AppVeyorBot
Copy link

AppVeyor build 1.0.2525 for commit 0f05d6b is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 marked this pull request as ready for review December 1, 2020 17:01
@AppVeyorBot
Copy link

AppVeyor build 1.0.2527 for commit a4c45f5 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 marked this pull request as draft December 3, 2020 18:31
@RLordan
Copy link
Collaborator

RLordan commented Dec 8, 2020

Looks great, easy to follow.

@rando2 rando2 marked this pull request as ready for review December 17, 2020 18:41
@AppVeyorBot
Copy link

AppVeyor build 1.0.2528 ...

Found 0 potential spelling error(s). Preview: for commit d5c5262 is now complete. The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 added the Text for Review Feedback on this text is welcome! label Dec 17, 2020
@rando2
Copy link
Contributor Author

rando2 commented Dec 17, 2020

@RLordan if this looks ok to you, would you mind approving it? Excited to finish up the therapeutics section!!! 🎉

Copy link
Contributor

@ajlee21 ajlee21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just to clarify, is the idea that you're adding individual introduction and discussion sections to each of the different sections (i.e. therapeutics, methods, pathogenesis)?

@rando2
Copy link
Contributor Author

rando2 commented Dec 21, 2020

@ajlee21 The journal actually requested that we split it up into a bunch of shorter papers! So this will be a special issue instead of a single paper. What I'm working on now is spreading all the info out among the separate papers! #731 for more info if you want it!

@rando2 rando2 merged commit afd156b into greenelab:master Dec 21, 2020
@rando2 rando2 deleted the split-general branch December 21, 2020 14:19
@RLordan
Copy link
Collaborator

RLordan commented Dec 21, 2020

@RLordan if this looks ok to you, would you mind approving it? Excited to finish up the therapeutics section!!! 🎉
Sorry @rando2 I was traveling. I will have the check list for nutraceuticals ready before tomorrow. Thank you!

@rando2
Copy link
Contributor Author

rando2 commented Dec 21, 2020

Safe travels @RLordan! I know this is often a very busy time of year! Enjoy your UPenn holidays!

@RLordan
Copy link
Collaborator

RLordan commented Dec 21, 2020

Thanks a million @rando2! Delighted to see the journals interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Text for Review Feedback on this text is welcome!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants