-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split general content (intro, discussion) across sections #735
Conversation
I definitely agree with this. One round of pull requests can remap existing content into files. Then a separate round of pull requests can rephrase and edit as needed. |
AppVeyor build 1.0.2525 for commit 0f05d6b is now complete. Found 0 potential spelling error(s). Preview:... |
AppVeyor build 1.0.2527 for commit a4c45f5 is now complete. Found 0 potential spelling error(s). Preview:... |
Looks great, easy to follow. |
AppVeyor build 1.0.2528 ... Found 0 potential spelling error(s). Preview:for commit d5c5262 is now complete. The rendered manuscript from this build is temporarily available for download at: |
@RLordan if this looks ok to you, would you mind approving it? Excited to finish up the therapeutics section!!! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just to clarify, is the idea that you're adding individual introduction and discussion sections to each of the different sections (i.e. therapeutics, methods, pathogenesis)?
Safe travels @RLordan! I know this is often a very busy time of year! Enjoy your UPenn holidays! |
Thanks a million @rando2! Delighted to see the journals interest |
[ci skip] This build is based on afd156b. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/afd156b5bcc254c41be05683e8b1cd78f22f2ae3/checks https://github.com/greenelab/covid19-review/runs/435940762
[ci skip] This build is based on afd156b. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/afd156b5bcc254c41be05683e8b1cd78f22f2ae3/checks https://github.com/greenelab/covid19-review/runs/435940762
Description of the proposed additions or changes
This is a general proposal of how to move around the material from the intro and discussion. It is not incorporated very fluidly into the new locations in this PR, but I think separating these processes out will make it a lot easier to track the history of who worked on what!
Related issues
This is rebased on top of #734, so should not be merged until after that one is. Right now the changes proposed in #734 are also proposed here. I'm marking it as a draft to make sure there is no issue.
Suggested reviewers (optional)
Checklist