Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image building (e.g. using Buildah instead of Docker) #66

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

n-thumann
Copy link
Member

@n-thumann n-thumann commented Nov 12, 2024

What

This PR

  • changes Docker with Podman / Buildah to build, test and push our images (fixes currently broken workflow)
  • disables updating of images by default
  • includes the registry in the baseimage name
  • pins our workflow dependencies.

Why

Docker dropped support for Docker Image Format v1 and Docker Image manifest version 2, schema 1. Old images, like we are depending on in this repo, are still using those deprecated versions though. Buildah / Podman still have support for those.
If those older images are converted to version 2, schema 2 at some point, we could go back to Docker.

I also disabled the updating of images by default. My intention back then was to provide mostly up-to-date images, but we actually want rather non-update / vulnerable images in this repo. Besides that, updating the images lead to build issues in the past.

Including the registry in the baseimage is is good idea, because we then explicitly instead of implicitly use Docker Hub. Buildah / Podman might use other registries instead otherwise.

Pinning the workflow dependencies as been done, as requested by DevOps / generally a good idea.

References

Fixes VTA-589

Checklist

  • Tests

@n-thumann n-thumann changed the title Use Podman / Buildah to build, test and push images + pins dependencies Use Podman / Buildah to build, test and push images & pin dependencies Nov 12, 2024
@n-thumann n-thumann changed the title Use Podman / Buildah to build, test and push images & pin dependencies Refactor image building (e.g. using Buildah instead of Docker) Nov 12, 2024
@n-thumann n-thumann marked this pull request as ready for review November 12, 2024 16:09
@n-thumann n-thumann requested review from a team as code owners November 12, 2024 16:09
@n-thumann n-thumann merged commit a80b45f into main Nov 13, 2024
107 checks passed
@n-thumann n-thumann deleted the use_podman branch November 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants