Refactor image building (e.g. using Buildah instead of Docker) #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR
Why
Docker dropped support for Docker Image Format v1 and Docker Image manifest version 2, schema 1. Old images, like we are depending on in this repo, are still using those deprecated versions though. Buildah / Podman still have support for those.
If those older images are converted to version 2, schema 2 at some point, we could go back to Docker.
I also disabled the updating of images by default. My intention back then was to provide mostly up-to-date images, but we actually want rather non-update / vulnerable images in this repo. Besides that, updating the images lead to build issues in the past.
Including the registry in the baseimage is is good idea, because we then explicitly instead of implicitly use Docker Hub. Buildah / Podman might use other registries instead otherwise.
Pinning the workflow dependencies as been done, as requested by DevOps / generally a good idea.
References
Fixes VTA-589
Checklist