Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use [skip ci] for "automatic adjustments after a release" commit #991

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Feb 29, 2024

What

Use [skip ci] for "automatic adjustments after a release" commit

Why

I don't think it is necessary to run the CI on this commit ... we can save some CI/CD minutes.
This commit basically only adjusts the version to a dev version, which should never break any build, test, lint, docker build or build docs step- thus skip running.

@y0urself y0urself requested a review from a team as a code owner February 29, 2024 19:19
@greenbonebot greenbonebot enabled auto-merge (rebase) February 29, 2024 19:19
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@y0urself
Copy link
Member Author

my commit message skipped the CI 🙃

bjoernricks
bjoernricks previously approved these changes Mar 1, 2024
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this change and at first sight I would prefer a CLI flag for this. But as this code is already full of flags and code branches I will just approve it.

@y0urself y0urself disabled auto-merge March 4, 2024 08:32
@y0urself y0urself enabled auto-merge (squash) March 4, 2024 08:32
@y0urself y0urself added the make release To trigger GitHub release action. label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (5c5190a) to head (9880c74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files         103      103           
  Lines        6958     6958           
  Branches      986      986           
=======================================
  Hits         6288     6288           
  Misses        471      471           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0urself y0urself merged commit d7f417c into main Mar 4, 2024
21 checks passed
@y0urself y0urself deleted the y0urself/skip-ci branch March 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants