Release repository argument #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't maintain the return values by hand and instead use auto.
GitHub always uses the owner/name combination for defining the repository. Therefore add a function that converts this repository into a owner name (space project) tuple.
GitHub always uses the owner/name combination for identifying a repository. Therefore we should allow passing this as input for creating and signing releases.
Conventional Commits Report
🚀 Conventional commits found. |
y0urself
requested changes
Feb 5, 2024
Of course we can do that. Personally I would love to get rid of space/owner and project completely and replaces all with repository. But this should go into another PR. |
I thought you will leave it for compatibility reasons ... |
y0urself
approved these changes
Feb 5, 2024
Maybe we just drop it after the actions and workflow are adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow to pass
--repositoryinstead of--spaceand--projecttopontos-releasecreateandsign.Why
GitHub nearly always passes an "owner/name" combination for identifying the repository. Therefore we should support this pattern too. For example this is the only way to get the repo in an action from
${{ github.repository }}via the github contextChecklist