Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add additional comparison for Version classes (ge, lt and le) #923

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Add additional comparison for Version classes (ge, lt and le)

Why

Allow to compare versions with greater or equal then, less then and less or equal then. This is required for comparing CPE versions.

Checklist

  • Tests

@bjoernricks bjoernricks added the make release To trigger GitHub release action. label Nov 8, 2023
@bjoernricks bjoernricks requested a review from a team as a code owner November 8, 2023 10:47
@greenbonebot greenbonebot enabled auto-merge (rebase) November 8, 2023 10:47
Copy link

github-actions bot commented Nov 8, 2023

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #923 (570d7c7) into main (fe6835f) will decrease coverage by 0.17%.
The diff coverage is 67.39%.

❗ Current head 570d7c7 differs from pull request most recent head 2a240af. Consider uploading reports for the commit 2a240af to get more accurate results

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   90.43%   90.27%   -0.17%     
==========================================
  Files          97       95       -2     
  Lines        6745     6703      -42     
  Branches      968      965       -3     
==========================================
- Hits         6100     6051      -49     
- Misses        441      446       +5     
- Partials      204      206       +2     
Files Coverage Δ
pontos/version/version.py 91.25% <66.66%> (-3.12%) ⬇️
pontos/version/schemes/_pep440.py 87.70% <66.66%> (-1.12%) ⬇️
pontos/version/schemes/_semantic.py 92.38% <68.42%> (+0.38%) ⬆️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Allow to compare versions with greater or equal then, less then and less
or equal then. This is required for comparing CPE versions.
@greenbonebot greenbonebot merged commit 0161cec into main Nov 10, 2023
18 checks passed
@greenbonebot greenbonebot deleted the version-comparision branch November 10, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants