Skip to content

Commit

Permalink
Merge pull request #150 from greenbone/y0urself/fix-signing
Browse files Browse the repository at this point in the history
Fix the Release Workflow CI
  • Loading branch information
bjoernricks authored Jul 2, 2021
2 parents 34ce2bf + 7160dce commit dc04aec
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-pontos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Sign assets with pontos
run: |
echo "Signing assets for ${{env.VERSION}}"
echo -e "${{ env.GPG_PASSPHRASE }}" >> tmp.file
echo -e "${{ env.GPG_KEY }}" >> tmp.file
gpg --import tmp.file && rm tmp.file
poetry run pontos-release sign \
--signing-key ${{ env.GPG_FINGERPRINT }} \
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Calendar Versioning](https://calver.org).
### Deprecated
### Removed
### Fixed
* Do not print passphrase [#150](https://github.com/greenbone/pontos/pull/150)

[Unreleased]: https://github.com/greenbone/pontos/compare/v21.7.0...HEAD

Expand Down
5 changes: 4 additions & 1 deletion pontos/release/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,10 @@ def main(
):
return sys.exit(1) if leave else False
except subprocess.CalledProcessError as e:
error(f'Could not run command "{e.cmd}".')
if not '--passphrase' in e.cmd:
error(f'Could not run command "{e.cmd}".')
else:
error('Headless signing failed.')
out(f'Error was: {e.stderr}')
sys.exit(1)

Expand Down

0 comments on commit dc04aec

Please sign in to comment.