refactor: move scanner traits to model crate and introduce result struct #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nichtsfrei
commented
Feb 27, 2024
•
nichtsfrei
commented
- Change: move osp specific Scanner implementation from openvasd into osp
- Change: move scanner trait to models library
- Change: remove FetchResult in favor of ScanResults
nichtsfrei
force-pushed
the
preparation-for-scheduler
branch
from
a8144a1 to
6603e67
Compare
Instead of using a tuple of (Status, [Result]) a struct ScanResults is introduced. This will help us to create bulk retrieving operations on implementations that makes sense. Although the benefits are currently minimal when we introduce a scheduler for scans it will make it easier to handle results in that fashion.
nichtsfrei
force-pushed
the
preparation-for-scheduler
branch
from
6603e67 to
7b64d0b
Compare
To be able to reuse the traits for openvasd they're moved into the models crate inside models::scanner module. This allows us to implement the technology specific scanner inside their traits and a scheduler using them instead of having to implement multiple schedulers inside the technology specific crates.
nichtsfrei
changed the title
nichtsfrei
force-pushed
the
preparation-for-scheduler
branch
from
2a088ee to
b869030
Compare
jjnicola
previously approved these changes
Feb 28, 2024
nichtsfrei
force-pushed
the
preparation-for-scheduler
branch
from
b869030 to
c885d35
Compare
jjnicola
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.