Change: set Scan ID of Scan Model to non-optional #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraemii
force-pushed
the
rs-adjust-scan-model
branch
from
abf2686 to
5201a7c
Compare
nichtsfrei
reviewed
Feb 15, 2024
Kraemii
force-pushed
the
rs-adjust-scan-model
branch
from
5201a7c to
815d005
Compare
nichtsfrei
reviewed
Feb 19, 2024
Kraemii
force-pushed
the
rs-adjust-scan-model
branch
2 times, most recently
from
a957dad to
58f8655
Compare
As the scan ID was set by the server and not by the client, it was set to Optional. This lead to many unnecessary checks, even though it was not possible, that this value is None.
Kraemii
force-pushed
the
rs-adjust-scan-model
branch
from
58f8655 to
28be075
Compare
nichtsfrei
approved these changes
Feb 21, 2024
jjnicola
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the scan ID was set by the server and not by the client, it was set to Optional. This lead to many unnecessary checks, even though it was not possible, that this value is None.
SC-1021