Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm test #1554

Merged
merged 4 commits into from
Jan 16, 2024
Merged

fix helm test #1554

merged 4 commits into from
Jan 16, 2024

Conversation

nichtsfrei
Copy link
Member

@nichtsfrei nichtsfrei commented Jan 15, 2024

  • Fix: helm: notus-data uses a tar.gz file
  • Change: helm: rename server-private-key to ingress-certificate

SC-1009

Within the latest changes of the notus-feed it was decided that an image
contains just the tar.gz file, forcing us to utilize the init.sh script.

Since the same is planned for vulnerability-tests the deployment is also
changed to utilize the init.sh script instead of doing that as a
command.
@nichtsfrei nichtsfrei force-pushed the fix-helm-test branch 2 times, most recently from 7c643a3 to 237287c Compare January 16, 2024 09:37
To be more inline with internal naming-schemes server-private-key is
renamed to ingress-certificate.
Remvoves clippy warnings from newer clippy version
@nichtsfrei nichtsfrei marked this pull request as ready for review January 16, 2024 09:48
@nichtsfrei nichtsfrei requested review from a team as code owners January 16, 2024 09:48
@nichtsfrei nichtsfrei enabled auto-merge (rebase) January 16, 2024 09:48
jjnicola
jjnicola previously approved these changes Jan 16, 2024
@nichtsfrei nichtsfrei disabled auto-merge January 16, 2024 13:00
@nichtsfrei nichtsfrei merged commit 3af2609 into main Jan 16, 2024
28 of 29 checks passed
@nichtsfrei nichtsfrei deleted the fix-helm-test branch January 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants