Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve implementations, code style, and tests #33

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

turbolent
Copy link
Contributor

  • Use the latest version of the Flow CLI, the Cadence 1.0 preview release is outdated
  • Make the code more consistent, by fixing whitespace, improving argument labels, removing unnecessary type annotations, etc.
  • Replace implementations with functions (e.g. String.contains) and functionality (e.g. InclusiveRange) built into Cadence now. In some cases this makes the code much more efficient, e.g. InclusiveRange does not allocate a whole array of indices like before
  • Extend the test cases

contracts/ArrayUtils.cdc Outdated Show resolved Hide resolved
contracts/ArrayUtils.cdc Outdated Show resolved Hide resolved
@turbolent turbolent requested a review from bluesign October 25, 2024 17:03
@turbolent turbolent requested a review from bjartek October 30, 2024 16:04
@turbolent
Copy link
Contributor Author

@bjartek @austinkline Would be great to get this merged, so we can update the Cadence Source Compatibility Suite, which currently uses a fork with these changes: https://github.com/onflow/cadence/blob/master/compat/suite/green-goo-dao-flow-utils.yaml

Copy link
Contributor

@austinkline austinkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @bjartek any objections?

@bjartek
Copy link
Contributor

bjartek commented Nov 3, 2024

No

@austinkline austinkline merged commit 5f8135d into green-goo-dao:main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants