-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve implementations, code style, and tests #33
Conversation
@bjartek @austinkline Would be great to get this merged, so we can update the Cadence Source Compatibility Suite, which currently uses a fork with these changes: https://github.com/onflow/cadence/blob/master/compat/suite/green-goo-dao-flow-utils.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @bjartek any objections?
No |
String.contains
) and functionality (e.g.InclusiveRange
) built into Cadence now. In some cases this makes the code much more efficient, e.g.InclusiveRange
does not allocate a whole array of indices like before