add contract that handles destruction of resources with an optional callback interface

[austinkline]

No description provided.

[joshuahannan]

Great work! I'd love to get something like this that we can deploy to the service account or another core flow account that so it can effectively be a core contract or something like that. What do you think about making this as a PR to flow-core-contracts? I could do it for you if that would be easier. I could make a FLIP about adding it to the service account

[austinkline]

Great work! I'd love to get something like this that we can deploy to the service account or another core flow account that so it can effectively be a core contract or something like that. What do you think about making this as a PR to flow-core-contracts? I could do it for you if that would be easier. I could make a FLIP about adding it to the service account

Not opposed to this living elsewhere, is there a way for us to structure this such that it takes the FungibleToken burn method as well? We had some work to do there to get event emissions when a non-0 vault was burned anyway. Is this a sufficient to get us there?

I'll make the PR, good chance to contribute to flow-core-contracts finally

[FelipeRibeiroLabs]

This looks great! Thank you @austinkline

[austinkline]

Made some new adjustments to handle Array and Dictionary types since those are resources but wouldn't handle their respective callbacks appropriately. I'm not sure if all the key types are covered or not, but this is a good starting point

[turbolent]

I'm a bit worried to call this "safe", as it still allows arbitrary code to be run, which could be re-entrant. This was one of the reasons why custom resource destructors where removed.

[austinkline]

I'm a bit worried to call this "safe", as it still allows arbitrary code to be run, which could be re-entrant. This was one of the reasons why custom resource destructors where removed.

I'll rename the test contract, but @bluesign and I discussed names last night and settled on:

• Burner (contract)
• Burnable (interface)
• burn (global method)

Any concerns with that?

[austinkline]

@joshuahannan made a PR to the core contracts repo here:
onflow/flow-core-contracts#407