Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass WooCommerce 3.0 compatibility. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

first pass WooCommerce 3.0 compatibility. #11

wants to merge 1 commit into from

Conversation

helgatheviking
Copy link

Notes:

  1. back-compatibility with pre-3.0 is not preserved. To preserve it you would need to write a helper function that always checks the WooCommerce version number and returns $product->id or $product->get_id() as appropriate.
  2. product data is not saved via CRUD. But get_post_meta() and update_post_meta() are still viable.

…s not preserved 2: product data is not saved via CRUD
@madebycaliper
Copy link

I just spent the last hour going through this on my local install so I could quiet down the PHP warnings... @greatwitenorth it would be awesome if you could merge this PR into master! (I think there's another one waiting on the list that has some WC 3.0+ fixes too, though they might be redundant)

gine pushed a commit to gine/quantities-and-units-for-woocommerce that referenced this pull request Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants