Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-#310-running-Firefox-94.0-detection #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rstech209
Copy link

Solution meeting the following constraints:

  • In the standard case, the commands currently used are correct pgrep/pkill -x -u "$user" "$PSNAME"
  • For Firefox, Librewolf (or other?), do not use the command line pattern only: in this case all the processes and sub-processes containing the word 'firefox' in their command line will be taken into account for detection ( running_check ()) and stopped (kill_browsers ()).
  • Do not rely solely on the process name 'GeckoMain' => how to differentiate Firefox and Librewolf for example?
  • Case scenario: psd configured with BROWSERS=firefox
    a) leafpad firefox_text running => psd does not start if you match the command line only.
    b) librewolf running => psd does not start believing it is firefox (do not rely solely on the name of the process 'GeckoMain')
    c) firefox + librewolf running => 2 GeckoMain processes, but only one should be considered as running because BROWSERS=firefox
    d) For 2 simultaneous firefox processes running (possible with 2 different versions of firefox) => take into account the 2 GeckoMain processes

@rstech209 rstech209 changed the title Update profile-sync-daemon.in Fix-#310-running-Firefox-94.0-detection Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant